Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation e2e selector updates #1496

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Validation e2e selector updates #1496

merged 7 commits into from
Feb 5, 2025
+22 −18

Conversation

vsvishalsharma
Copy link
Contributor

@vsvishalsharma vsvishalsharma commented Feb 3, 2025 •
edited by jira bot
Loading

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

#1497
OGC-36

[Add any additional information or notes here]

mozzy11
mozzy11 previously approved these changes Feb 5, 2025
View reviewed changes
@mozzy11
Copy link
Collaborator

mozzy11 commented Feb 5, 2025

Thanks @vsvishalsharma .
Can you run npm run format in your frontend to format your code ??
The CI build fails

@vsvishalsharma
Copy link
Contributor Author

Yeah sure @mozzy11

@vsvishalsharma
Copy link
Contributor Author

vsvishalsharma commented Feb 5, 2025 •
edited
Loading

@mozzy11 I have updated and resolved the ci failure pls review

@vsvishalsharma
Copy link
Contributor Author

Your previous approval was dismissed with the fix commit @mozzy11

@mozzy11 mozzy11 merged commit 381f29c into I-TECH-UW:develop Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzy11 mozzy11 Awaiting requested review from mozzy11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsvishalsharma @mozzy11